Jump to content

Philip Petev

Philip Petev

Member Since 13 Oct 2006
Offline Last Active Today, 03:03 PM
*****

#2546803 Clover Bug/Issue Report and Patch

Posted by Philip Petev on 08 December 2017 - 07:10 PM

And yet, RehabMan's fork is pretty good example how all this maintenance can be done with minimum effort. Not sure why the keyword is "git", git and subversion are practically the same thing, git just has more features.... Yes, they basically are, only that those "features" matter in the current case.
  • nms likes this

#2546249 Clover Bug/Issue Report and Patch

Posted by Philip Petev on 08 December 2017 - 06:57 AM

Yes, it is a possible way. Other way is to stay with some UDK, for example UDK2017n @Slice @RehabMan I think the question you devs should ask yourself is do we really need the branch edk2 (the rolling release, constantly updated) or the branch udk2017 (the stable one, receiving only the critical updates from the edk2 branch from time to time) is quite enough in term of set of features it offers. We all know Clover uses only some of the toolkit modules and the rest are being updated more often in that rolling release according to my observations.

#2544914 Clover Bug/Issue Report and Patch

Posted by Philip Petev on 06 December 2017 - 08:32 AM

 Ok, the problem is actually in svn commit 25815 that adds some code to GenSec.c that doesn't compile with Xcode.  The tool wasn't built, so I didn't have it which is why the build broke. Here's a patch to fix GenSec.cdiff a/BaseTools/Source/C/GenSec/GenSec.c b/BaseTools/Source/C/GenSec/GenSec.c--- a/BaseTools/Source/C/GenSec/GenSec.c+++ b/BaseTools/Source/C/GenSec/GenSec.c@@ -1034,9 +1034,9 @@ Returns: CHAR8 *DummyFileName; FILE *DummyFile; UINTN DummyFileSize;- UINT8 *DummyFileBuffer;+ CHAR8 *DummyFileBuffer; FILE *InFile;- UINT8 *InFileBuffer;+ CHAR8 *InFileBuffer; UINTN InFileSize; InputFileAlign = NULL;@@ -1326,13 +1326,13 @@ Returns: DummyFile = fopen (LongFilePath (DummyFileName), "rb"); if (DummyFile == NULL) { Error (NULL, 0, 0001, "Erro...

#2543093 Build_Clover.command, another Script to build standard Clover (or customized)

Posted by Philip Petev on 02 December 2017 - 06:18 PM

Just updated the script. It now supports those changes. To ensure you have the latest nasm binary, just remove the current one withrm -f ~/src/opt/local/bin/nasmTo ensure you have the GCC7 toolchain, it's recommended to remove the following two folders:~/src/opt~/src/toolsNote that you should set the toolchain as default (Build_Tool=GNU in BuildCloverConfig.txt) in order to download and build it.I've also merged the other changes from the work branch such as the non-interactive mode, so it's recommended to remove your settings file and let the script create a new one.

#2538641 Build_Clover.command, another Script to build standard Clover (or customized)

Posted by Philip Petev on 23 November 2017 - 09:48 AM

That's probably something with the buildpkg.sh script, not with this one. Will take a look into it, when I find some time.

#2536129 Clover Bug/Issue Report and Patch

Posted by Philip Petev on 17 November 2017 - 09:33 PM

Hi Zenith432,I think it will be interesting for you.I noticed this bug many revisions ago and now I was clearly reproduced it.1. Updated EDK2 and Clover to latest revision.2. Compile with ./ebuilds.sh -t XCODE83. Compile with ./ebuilds.sh -t XCODE5Compare resultsXcode8screenshot11.pngXcode5screenshot12.png This is same sources rev4304, same computer #1, same macOS 10.12.6, and same XCode 9.1.The results are different by different toolset.Affected only embedded theme.Any thought?I can append that the result with GCC is pretty much the same as with XCODE8.

#2530906 Clover Configurator 4.55 breaks audio! be aware!

Posted by Philip Petev on 08 November 2017 - 07:27 AM

I wonder what CC might corrupt in such configuration. The AppleALC/Lilu combo doesn't require any patches through Clover, except maybe injecting the right audio layout ID, if your DSDT is not already patched for that.CC breaks sometimes configs that contain new options (introduced in Clover, but not included in CC yet), but that's completely different story.

#2528275 Clover General discussion

Posted by Philip Petev on 03 November 2017 - 12:41 PM

Probably that file was made manually, because the buildpkg.sh script still generates the name without that ".pkg".

#2527412 Build_Clover.command, another Script to build standard Clover (or customized)

Posted by Philip Petev on 02 November 2017 - 11:37 AM

Awesome, thank you! One additional feature/option I'd like to see is to force it to update everything first, then run a build, which is how I currently have it setup, by simply enabling both UPDATE_FLAG=YES and BUILD_FLAG=YES.This way it's easy to build an always up to date version, but again entirely non-interactively.Yes, with both UPDATE_FLAG and BUILD_FLAG, set to YES, the script will always try to update the Clover (and edk2, if there's a new recommended version) source before building it. In addition, I've added the ForceEDK2Update option to the config, which set to non-zero, will force the edk2 source update and rebuild the edk2 Basetools.

#2527307 Build_Clover.command, another Script to build standard Clover (or customized)

Posted by Philip Petev on 02 November 2017 - 08:49 AM

I understood from the usage section that the script can skip interactive menus entirely if at least a single argument is provided, but that doesn't seem to be the case. No matter what argument I provide, it always shows the menus. I'm trying to automate it to a single command, but from what I can tell the script doesn't support fully headless/non-interactive running? EDIT: Maybe just allow something like this to override build options?FORCEREBUILD="-fr" UPDATE_FLAG="NO" BUILD_FLAG="YES" ARCH="X64" buildcloverEDIT 2: Found a workaround by adding the following to "var_defaults": "FORCEREBUILD",,, "UPDATE_FLAG",,,"YES" "BUILD_FLAG",,,"NO" "ARCH",,, )This way I can simply override them in the config file, which seems to work perfectly for running in headless/non-interactive mode.Note that I also had to change the logic in the build() function to take into account if these values are set/overwritten.That's actually a good one. Worked on that yesterday and now the beta branch su...

#2522627 Build_Clover.command, another Script to build standard Clover (or customized)

Posted by Philip Petev on 26 October 2017 - 07:20 AM

Running under Ubuntu 17.10, on ~/BuildCloverConfig.txt, "Build_tool=XCODE" is still as it, I manually changed it to =GCC but also produces same result, thanks. That option is not even considered by the script, running on Linux. GCC53 is used by default, so editing it and the "XCODE=" options has no effect on Linux.

#2522624 Clover General discussion

Posted by Philip Petev on 26 October 2017 - 07:15 AM

Building from @rehabman's GIT repo needs XCODE8 setting. Actually, RehabMan has initially adapted only this profile, but the rest can be used as well. You can build RehabMan's fork with XCODE5, GCC53, GCC49 and even the little known XCLANG (Xcode is required) profile, using the attached file. EDIT: both the XCODE32 and XCLANG profiles have been retired in favor of the XCODE5 profile almost 6 months ago.Reference: https://github.com/t...c25f14f01ccf0b7 Attached Files  tools_def.txt 451.51KB 8 downloads

#2522612 Build_Clover.command, another Script to build standard Clover (or customized)

Posted by Philip Petev on 26 October 2017 - 06:41 AM

I'll try to reproduce the problem, there's nothing unusual in your log though. EDIT: just tested it, happens to me too. It seems the GCC53 profile is not fully compatible with GCC 7.x, so until someone more experienced in that matter figure out a new one, it will (not) work this way.

#2520974 Build_Clover.command, another Script to build standard Clover (or customized)

Posted by Philip Petev on 22 October 2017 - 07:34 PM

You don't need to remove the whole ~/src folder, removing only the edk2 subfolder is enough.

#2520970 Build_Clover.command, another Script to build standard Clover (or customized)

Posted by Philip Petev on 22 October 2017 - 07:29 PM

I know, just tested it, works here too.

© 2017 InsanelyMac  |   News  |   Forum  |   Downloads  |   OSx86 Wiki  |   Designed by Ed Gain  |   Logo by irfan  |   Privacy Policy