I made some more progress and tried and would like to share this:
- This setup does work for an X260 also - exactly the same build and all that - so its as is compatible for T460 and X260 ( verified ). This includes all DSDTs, premade ones and self mades - thats pretty awesome!
- you should make clear in your ACPI guide, that SSDT must _stiil_ be copied from the patched folder of your ESP, since they are not generated during the patching. Generating own ACPI tables and patching them does for now only generate a DSDT.aml, no SSDTs at all. That said, the system will not boot without the SSDTs, it will only boot with intelinject/fakeid eventhough the framebuffer patch is included. So those files are for now needed and that needs to be in that guide i guess
- your install_acpi.bash requires the EFI partition to be mounted in /Volumes/ESP, while you do automount using espmount.bash 0 - this does mount it as /Volumes/ESP-0 if any other ESP partition is found in addition, be it the boot stick, a seconds OS or whatever. That said, it should rather not automount but check that /Volumes/ESP exists ( so is mounted ) and require the user to do so otherwise (or install fail )
- SSDT would never be used for patching, they are never used from the ACPI-tables. Probably that is what you wanted?
- Scripts have 'set -e' and have been made a bit more robust
- i moved the initial iasl -dl ... SS* DD* command into the create command and fixed some glitches with result folders not being there yet, so it can be removed from the tutorial to make it simpler
- if /Volumes/ESP does not exist, do warn the user and fail in install_acpi.bash
- do no longer require iasl to be local (./iasl), since iasl is required to be in $PATH by the patchmatic_auto_patch.bash script anyway
You find both scripts here https://gist.github....7f720eefa29c983
I updated the zip today with a revised AppleALC (and Lilu) build.
This version does all the kext patching for SkyLake Graphics Framebuffer (including the dreaded DVMT KP) as well for AppleHDA that was previously done via Clover kext patch. I chose to add the AppleALC kext as this approach/method was already patching the SKL FB and adding a variety of extra patches was a lot easier than coding them into sherlocks DVMTFixup kext - credit to sherlocks as this gave me the inspiration!
So with this new method, there is no need to add FakeID 12345678 for installing fresh etc. Just copy all these kexts to the ESP of your HD and your installer USB. It will use full SKL GFX during the installer phase now! I tested by installing 10.12.4 from scratch and then added the 10.12.5 beta updates. so far so good!
To move to this package:
use the new config.plist and merge/add your own custom items such as MLB/ROM item
install/replace the kexts in
1) ESP Other and
2) to your HD in /Library/Extensions
I am kind of confused, AppleALC is for audio right? how is that related to the Framebuffer issue / patch?
I guess for all of us which just need to know how to import the changes into our own EFI installation :
- copy <zip>/EFI/CLOVER/kexts/Other/AppleACL.kext to <OSX>/EFI/CLOVER/kexts/Other/AppleACL.kext
- Should the skylakeFB_patch.bash / skylakeFB_unpatch.bash be removed from the package then? (and you should remove it from the zip... i see it has been removed from the tutorial, great job)
- do i no longer need to patch the framebuffer after the installation at all? According to your statement, that FB is now available during the installation, i guess that is the case?
- did the Lilu.kext also change?
Do you mind to put the ZIP on a github repo so contribution and change-tracking is easier?