Jump to content

Clover Problems and Solutions

ErmaC

By ErmaC,
in Clover Development

 Share
3,206 posts in this topic

Recommended Posts

Pene
Pene
Posted
Posted (edited)
11 hours ago, Slice said:

Is python critical to correct identation?

Yes, indentation is critical in Python. A code block (for conditionals, loops and so on) starts with a specific indentation (which must be kept constant, to keep the same block) and ends with the first line that is unindented.

 

11 hours ago, Slice said:

We should update Python tools at least.

Which revision did you update to? latest?

 

 

@vector sigma

Anything against replacing in buildme: 

cd "$(dirname $0)"

with something like: 

cd "$(dirname "$(readlink "$0")")"

in order to allow the script to function even if we make a symlink to it somewhere.

Edited by Pene
Link to comment
Share on other sites
Slice
Slice
Posted
Posted
1 hour ago, Pene said:

Yes, indentation is critical in Python. A code block (for conditionals, loops and so on) starts with a specific indentation (which must be kept constant, to keep the same block) and ends with the first line that is unindented.

 

Which revision did you update to? latest?

 

 

 

 

today version

  • Like 1
Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted
2 hours ago, Pene said:

Anything against replacing in buildme: 


cd "$(dirname $0)"

with something like: 


cd "$(dirname "$(readlink "$0")")"

in order to allow the script to function even if we make a symlink to it somewhere.

Yes because this way will work only if it is a symlink. But, can you test the following instead? 

cd "$(dirname $([ -L $0 ] && readlink $0 || echo $0))"

and then I need to know if works under Linux as well before changing it.

Link to comment
Share on other sites
Pene
Pene
Posted
Posted
11 hours ago, vector sigma said:

Yes because this way will work only if it is a symlink. But, can you test the following instead? 


cd "$(dirname $([ -L $0 ] && readlink $0 || echo $0))"

and then I need to know if works under Linux as well before changing it.

readlink works also if its not a symlink, but your suggestion works fine also here.

Unfortunatenly I don't have access to Linux atm, so someone else should test that

Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted
6 hours ago, Pene said:

readlink works also if its not a symlink, but your suggestion works fine also here.

Unfortunatenly I don't have access to Linux atm, so someone else should test that

I mean if try ' 

cd "$(dirname "$(readlink "$0")")"

' I got this:

 

  

------------------------------------------------------------------------
cat: vers.txt: No such file or directory
buildme, Clover v2.5k r (SHA: not a git repo)

Anyway we can ask Mr. @fusion71au if can test the chage in Linux....

Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted
16 hours ago, Slice said:

Works!

Снимок экрана 2019-09-20 в 21.52.06.png

And clicking OK (Ага!) really download from github. Good work!

To ensure it alway work you just have to use the same tag method you used till now:

 

          <a href="/CloverHackyColor/CloverBootloader/releases/tag/5089">Release v2.5k-5089</a>

          <a href="/CloverHackyColor/CloverBootloader/releases/tag/5084">Release 2.5k-5084</a>

          <a href="/CloverHackyColor/CloverBootloader/releases/tag/5081">2.5k-5081</a>

          <a href="/CloverHackyColor/CloverBootloader/releases/tag/5078">Release 2.5k-5078</a>

          <a href="/CloverHackyColor/CloverBootloader/releases/tag/5071">Release 2.5k-5071</a>

 

see the red part, untill this exist the change I made will always work.

Link to comment
Share on other sites
Slice
Slice
Posted
Posted

OK, tags will be always numerated this way.

And about package numeration. Now it is Clover_v2.5k_r5089

May be can do like git? 

Dell:CloverHackyColor sergey$ git describe head --tags
5089-3-g9b3bfdb9
Dell:CloverHackyColor sergey$

So it will be Clover_v2.5k_r5089-3-g9b3bfdb9

 

Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted
1 hour ago, Slice said:

And about package numeration. Now it is Clover_v2.5k_r5089

May be can do like git? 


Dell:CloverHackyColor sergey$ git describe head --tags
5089-3-g9b3bfdb9
Dell:CloverHackyColor sergey$

So it will be Clover_v2.5k_r5089-3-g9b3bfdb9

 

This will break the Clover Updater again. Why not just make it appear in package instead?

1493144702_Schermata2019-09-21alle17_59_09.png.84f6ea73eedc7decca927ee3359ce356.png

Link to comment
Share on other sites
Slice
Slice
Posted
Posted
2 hours ago, vector sigma said:

This will break the Clover Updater again. Why not just make it appear in package instead?

1493144702_Schermata2019-09-21alle17_59_09.png.84f6ea73eedc7decca927ee3359ce356.png

OK, it will be good.

Next release will be MAX(sf, curRev+1) ;)

  • Like 1
Link to comment
Share on other sites
STLVNUB
STLVNUB
Posted
Posted (edited)

Need to export PREFIX=TOOLCHAIN_DIR at line 19 of buildme

buildgcc9 and buildgettext need this to install to right place.

 

I'm surprised nobody has picked up on this BUG, maybe nobody builds from

scratch

Edited by STLVNUB
Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted
12 hours ago, STLVNUB said:

Need to export PREFIX=TOOLCHAIN_DIR at line 19 of buildme

buildgcc9 and buildgettext need this to install to right place.

 

I'm surprised nobody has picked up on this BUG, maybe nobody builds from

scratch

It is the build_gcc9.sh that don't use TOOLCHAIN_DIR as it should: 

export PREFIX=${PREFIX:-~/src/opt/local}

instead of: 

TOOLCHAIN_DIR=${TOOLCHAIN_DIR:-~/src/opt/local}
export PREFIX=${PREFIX:-$TOOLCHAIN_DIR}

..not sure why.

Link to comment
Share on other sites
Pene
Pene
Posted
Posted (edited)
On 9/21/2019 at 2:15 PM, vector sigma said:

' I got this: 


------------------------------------------------------------------------
cat: vers.txt: No such file or directory
buildme, Clover v2.5k r (SHA: not a git repo)

Anyway we can ask Mr. @fusion71au if can test the chage in Linux....

 

Well on my system it worked even when not symlink, but it doesn't matter really. Your version:

On 9/20/2019 at 8:55 PM, vector sigma said:

  


cd "$(dirname $([ -L $0 ] && readlink $0 || echo $0))"

 

is probably better as it works on both of our system.

Remains to be tested in linux...

Edited by Pene
Link to comment
Share on other sites
STLVNUB
STLVNUB
Posted
Posted
18 hours ago, vector sigma said:

It is the build_gcc9.sh that don't use TOOLCHAIN_DIR as it should: 


export PREFIX=${PREFIX:-~/src/opt/local}

instead of: 


TOOLCHAIN_DIR=${TOOLCHAIN_DIR:-~/src/opt/local}
export PREFIX=${PREFIX:-$TOOLCHAIN_DIR}

..not sure why.

Yeah Gettext has same problem

Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted
15 hours ago, Pene said:

is probably better as it works on both of our system.

Remains to be tested in linux...

@fusion71au just tested it, so I committed the change. atm at github only

6 hours ago, STLVNUB said:

Yeah Gettext has same problem

At github (atm only), (should) I made buildme able to use gettext from any other locations already present in $PATH. Requisite is the presence of msmerge.

Link to comment
Share on other sites
vector sigma
vector sigma
Posted
Posted (edited)
2 hours ago, Slice said:

This moment I am not at home so I am not sure what gettext I really used. Maybe that installed by Macports in opt/local/bin.

old or new really doesn't care if can translate strings. buildme see if there is one available using 'which msmerge' that is supposed to return an array of paths like the following: 

/opt/local/bin/msmerge
/Users/Slice/src/opt/local/bin/msmerge
/usr/bin/msmerge

or just the more ralistic: 

/opt/local/bin/msmerge

if the array is not empty, buildme use the first element in the array and export GETTEXT_PREFIX=/opt/local/bin so that there's no need to build it in a different place.

 

P.S. msmerge comes installing gettext and needed by the build script.

Edited by vector sigma
Link to comment
Share on other sites
Slice
Slice
Posted
Posted

Dell:CloverHackyColor sergey$ which libtool
/usr/bin/libtool
Dell:CloverHackyColor sergey$ which gettext
/opt/local/bin/gettext
Dell:CloverHackyColor sergey$ which msmerge
Dell:CloverHackyColor sergey$

 

Dell:CloverHackyColor sergey$ gettext -V
gettext (GNU gettext-runtime) 0.19.8.1
Copyright (C) 1995-1997, 2000-2007 Free Software Foundation, Inc.
Лицензия GPLv3+: GNU GPL версии 3 или новее <http://gnu.org/licenses/gpl.html>
Это свободное ПО: вы можете продавать и распространять его.
Нет НИКАКИХ ГАРАНТИЙ до степени, разрешённой законом.
Автор программы ? Ульрих Дреппер (Ulrich Drepper).
Dell:CloverHackyColor sergey$

 

Link to comment
Share on other sites
Pene
Pene
Posted
Posted (edited)

Trying to compile with default gcc now I get this: 

Building ... /Users/asava/src/CloverBootloader/Protocols/SMCHelper/SMCHelper.inf [X64]
t-set-variable: In function 'StartupSoundPlay':
t-set-variable:175:9: internal compiler error: Segmentation fault: 11
libbacktrace could not find executable to open
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.
Building ... /Users/asava/src/CloverBootloader/Drivers/XhciDxe/XhciDxe.inf [X64]
make: Nothing to be done for `tbuild'.
make: *** [/Users/asava/src/CloverBootloader/Build/Clover/RELEASE_GCC53/X64/rEFIt_UEFI/refit/OUTPUT/Platform/StartupSound.obj] Error 1


build.py...
 : error 7000: Failed to execute command
	make tbuild [/Users/asava/src/CloverBootloader/Build/Clover/RELEASE_GCC53/X64/rEFIt_UEFI/refit]


build.py...
 : error F002: Failed to build module
	/Users/asava/src/CloverBootloader/rEFIt_UEFI/refit.inf [X64, GCC53, RELEASE]

- Failed -
Build end time: 20:13:10, Sep.23 2019
Build total time: 00:00:08

Anyone encounter?

With Xcode there was no such problem.

Edited by Pene
Link to comment
Share on other sites
Slice
Slice
Posted
Posted

"internal compiler error"? What is your default gcc?

Using built-in specs.
COLLECT_GCC=/Users/sergey/src/opt/local/cross/bin/x86_64-clover-linux-gnu-c++
COLLECT_LTO_WRAPPER=/Users/sergey/src/opt/local/cross/libexec/gcc/x86_64-clover-linux-gnu/9.2.0/lto-wrapper
Target: x86_64-clover-linux-gnu
Configured with: /Users/sergey/src/tools/gcc/gcc-9.2.0/configure --host=x86_64-apple-darwin18.7.0 --build=x86_64-apple-darwin18.7.0 --target=x86_64-clover-linux-gnu --prefix=/Users/sergey/src/opt/local/cross --with-gmp=/Users/sergey/src/opt/local --with-mpfr=/Users/sergey/src/opt/local --with-mpc=/Users/sergey/src/opt/local --with-isl=/Users/sergey/src/opt/local --with-system-zlib --with-gnu-as --with-gnu-ld --with-newlib --disable-libssp --disable-nls --disable-werror --enable-languages=c,c++ --enable-plugin --disable-isl-version-check
Thread model: posix
gcc version 9.2.0 (GCC)

 

Link to comment
Share on other sites
Slice
Slice
Posted
Posted
2 minutes ago, Pene said:

Clean Catalina system, I just run ./buildme.

It built the gcc and now this is the result.

I am on Mojave 10.14.6 with Xcode11.0 

- Done -
Build end time: 20:15:48, Sep.23 2019
Build total time: 00:04:20

 

Link to comment
Share on other sites
Slice
Slice
Posted
Posted
10 hours ago, Pene said:

With ./buildme? Using the gcc it builds?

Yes with buildme, but gcc already built by the script build_gcc9.sh

I see no reason to remake it.

May be my gcc9 was built before Xcode11. It was built when I had Xcode10.3.

Link to comment
Share on other sites
 Share
Go to topic listing
×
×
  • Create New...