Errors compiling SSDT - Asus G750JX

[gazzacbr]

Hi,

I have extracted the DSDT and 8 (!) SSDTs from my Asus G750JX.

I am preparing to try to patch them to add a brightness slider (not exactly sure how just yet).

 

My laptop has a 3D 120hz screen and needs an EFI string as OS X doesnt see the lcd connected to the internal display port.

(string kindly generated by AREOS http://www.insanelymac.com/forum/topic/293967-solved-asus-rog-laptops-with-kepler-cards-not-detecting-dp-2-connected-lcd-display/page-1 )

 

I have cleared errors etc from the DSDT and 7 of the SSDTs.

The 8th one (acpi_ssdt8.aml which contains graphics info) has this method _ROM screwed up:

Method (_ROM, 2, Serialized)  // _ROM: Read-Only Memory
 {
     If (RBUF (Add (Arg0, RBUF (Local0, ShiftLeft (Arg1, 0x03, Local1), 
         Name (VBUF, Buffer (Arg1) {}), OperationRegion (VROM, SystemMemory, Local0, 0x1000), Field (VROM, ByteAcc, NoLock, Preserve)
                     {
                         ROMI,   32768
                     }), Store (ROMI, VBUF)), Return (VBUF), Else
             {
                 Return (Buffer (One)
                 {
                      0x00
                 })
             })) {}
 }

I have edited to this and it compiled it to SSDT-7.aml but when i re-open the new compiled file the error is still there????

Method (_ROM, 2, Serialized)  // _ROM: Read-Only Memory
 {
   If (RBUF)
   {
     Add (Arg0, RBUF, Local0)
     ShiftLeft (Arg1, 0x03, Local1)
     Name (VBUF, Buffer (Arg1) {})
     OperationRegion (VROM, SystemMemory, Local0, 0x1000)
     Field (VROM, ByteAcc, NoLock, Preserve)
     {
         ROMI,   32768
     }
     Store (ROMI, VBUF)
     Return (VBUF)
   }
   Else
   {
      Return (Buffer (One)
      {
           0x00
      })
   }
 }

Can some kind person check this and tell me where I am going wrong?

 

p.s. if you can add in the brightness patch at the same time that would be great

 

thanks.

 

gazzacbr Asus G750JX.zip

[gazzacbr]

hmm, no one eh?

ok, easy one this time...

can some one just check this SSDT-7 Fixed.dsl.txt, compile it and reopen the compiled aml?

(extension .txt only added so i can attach it here)

pretty please.

 

(original extracted file attached also in acpi_ssdt8.zip)

 

i cleared the errors already and most warnings and can compile it.

when i reopen the .aml the ROM method errors are back.

 

thanks.

SSDT-7 Fixed.dsl.txt

acpi_ssdt8.zip

[RehabMan]

hmm, no one eh?

ok, easy one this time...

can some one just check this SSDT-7 Fixed.dsl.txt, compile it and reopen the compiled aml?

(extension .txt only added so i can attach it here)

pretty please.

 

(original extracted file attached also in acpi_ssdt8.zip)

 

i cleared the errors already and most warnings and can compile it.

when i reopen the .aml the ROM method errors are back.

 

thanks.

Normal/expected due to improper disassembly process.

[gazzacbr]

Hi,

@Rehabman: ok, so went back to basics.

the initial disassembly process was done, using the tables copied directly from linux, with iasl -d * 

then i edited the tables in mavericks with maciasl and also with dsdt editor and both showed the same errors.

but if i recompile directly in linux with iasl -tc the error is not there????

 

are maciasl and dsdt edit just not that good with multiple SSDTs?

or is there another way to use them?

[RehabMan]

Hi,

@Rehabman: ok, so went back to basics.

the initial disassembly process was done, using the tables copied directly from linux, with iasl -d * 

then i edited the tables in mavericks with maciasl and also with dsdt editor and both showed the same errors.

but if i recompile directly in linux with iasl -tc the error is not there????

 

are maciasl and dsdt edit just not that good with multiple SSDTs?

or is there another way to use them?

You cannot open AML files directly as that will cause them to be disassembled standalone. You always have to disassemble all files as a group. This is true both before and after patching.