Jump to content

Brightness DSDT Patching

Brightness; Ideadpad Z510

Best Answer RehabMan, 23 February 2014 - 05:17 PM

Hi, I tried to patch my SSDT with your GFX to IGPU patch and Brightness Haswell patch along with your ACPIbacklight.kext. I have the keyboard hotkey working. I can see the small sun, but adjusting the brightness will not have any effect on the backlight of laptop. I look at the AppleBacklighDisplay string my IOreg file, I can see that my currentpowerstate and max powerstate are both at 0x30. Do you know what could went wrong? I attached my IOReg file.


You have a PNLF device in DSDT and the SSDT. DSDT version will override/prevent SSDT version. Remove PNLF from DSDT.

Also, "Rename GFX0 to IGPU" should be applied to both DSDT and SSDT (you have renamed only SSDT). Go to the full post


  • Please log in to reply
72 replies to this topic

#1
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts
 

Hi

 

I have some trouble patching my DSDT to get my brightness working. I tried to patch my DSDT (thanks again for RehabMan for compiling the DSDT for me). I followed the tutorial  made by "ivik" at http://www.insanelymac.com/forum/topic/236835-updated-2012-genericbrightnesskext/. I tried both versions. None of them worked. I am wondering if I am doing something wrong.

 

From what I understand in the instruction, I need to input the code to my DSDT. I have no experience in programming. I am wondering what is the best way to input the code in DSDT editor. the format of the code from the aforementioned tutorial seems to be off. Do i reformat the code of I can just copy and paste?

 

Also, the tutorial aforementioned stated " ...you should find that device in dsdt. Under that device, there are other devices (usually LCD, CRT, TV...). Look for the device that has those methods (_BCM, _BCQ and _BCL) ". I cannot find any of these terms in my DSDT. I am not sure of the reason. Is that because of my GPU?  I also read that in order for brightness to work, the display0 should be AppleBacklightDisplay. but I only have AppleDisplay

 

I am currently using a intel HD 4600 GPU. the GPU is recognized, but with only 64mb of vram. I tried different Intel Azul FB value with GraphicsEnabler=Y , and none of them worked. and my scroll bar keeps flickering when I scroll. Similar thing happens in Launchpad.

 

Any help or would be appreciated. My DSDT, along with my IOReg and IOService screenshot are attached below.

 

CJ

 

Attached Files



#2
RehabMan

RehabMan

    InsanelyMac Legend

  • Coders
  • 1,097 posts
  • Gender:Male
  • Location:Bellingham, WA
  • Interests:skiing, software, classic cars

Hi
 
I have some trouble patching my DSDT to get my brightness working. I tried to patch my DSDT (thanks again for RehabMan for compiling the DSDT for me). I followed the tutorial  made by "ivik" at http://www.insanelym...brightnesskext/. I tried both versions. None of them worked. I am wondering if I am doing something wrong.
 
From what I understand in the instruction, I need to input the code to my DSDT. I have no experience in programming. I am wondering what is the best way to input the code in DSDT editor. the format of the code from the aforementioned tutorial seems to be off. Do i reformat the code of I can just copy and paste?
 
Also, the tutorial aforementioned stated " ...you should find that device in dsdt. Under that device, there are other devices (usually LCD, CRT, TV...). Look for the device that has those methods (_BCM, _BCQ and _BCL) ". I cannot find any of these terms in my DSDT. I am not sure of the reason. Is that because of my GPU?  I also read that in order for brightness to work, the display0 should be AppleBacklightDisplay. but I only have AppleDisplay
 
I am currently using a intel HD 4600 GPU. the GPU is recognized, but with only 64mb of vram. I tried different Intel Azul FB value with GraphicsEnabler=Y , and none of them worked. and my scroll bar keeps flickering when I scroll. Similar thing happens in Launchpad.
 
Any help or would be appreciated. My DSDT, along with my IOReg and IOService screenshot are attached below.
 
CJ


It is likely your ACPI backlight methods are not in DSDT. For most newer Haswell laptops, they are in one of the SSDTs.

Note that brightness with not work until you have QE/CI working for your graphics. (It is IntelAzulFB, not Intel Azul FB).

#3
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

It is likely your ACPI backlight methods are not in DSDT. For most newer Haswell laptops, they are in one of the SSDTs.

Note that brightness with not work until you have QE/CI working for your graphics. (It is IntelAzulFB, not Intel Azul FB).

 

 

Hi, Rehabman. Thank you for help me again. You are right. I found "Device GFX0" on one of the SSDT I compiled using Aida from Window OS. However, when I tried to compile it, I got 4 "Syntax error, unexpected PARSEOP_INTERGER" errors. They all pointed to 0x09 from 

 

    Method (_PRW, 0, NotSerialized)

    {

          Return (GPRW)

          0x09

          0x04

    } 

 

Do you know what could be wrong? I attached my SSDT file along with the reply. Thanks.

Attached Files



#4
RehabMan

RehabMan

    InsanelyMac Legend

  • Coders
  • 1,097 posts
  • Gender:Male
  • Location:Bellingham, WA
  • Interests:skiing, software, classic cars

Hi, Rehabman. Thank you for help me again. You are right. I found "Device GFX0" on one of the SSDT I compiled using Aida from Window OS. However, when I tried to compile it, I got 4 "Syntax error, unexpected PARSEOP_INTERGER" errors. They all pointed to 0x09 from 
 
    Method (_PRW, 0, NotSerialized)
    {
          Return (GPRW)
          0x09
          0x04
    } 
 
Do you know what could be wrong? I attached my SSDT file along with the reply. Thanks.


Make sure you disassemble it correctly. You must disassemble using iasl and all SSDT/DSDT:
# where ssdtX is the SSDT you're trying to disassemble.
iasl -e [all ssdt except ssdtX.aml] DSDT.aml -d ssdtX.aml
You must use a recent build of iasl.

#5
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

Make sure you disassemble it correctly. You must disassemble using iasl and all SSDT/DSDT:

# where ssdtX is the SSDT you're trying to disassemble.
iasl -e [all ssdt except ssdtX.aml] DSDT.aml -d ssdtX.aml
You must use a recent build of iasl.

 

 

Hello again, thanks for the info.  I tried the command line ./iasl -e [all ssdt except ssdtX.aml] DSDT.aml -d ssdtX.aml. But It gave the following error.

 

Loading Acpi table from file   ssdt.aml - Length 00013510 (0034C6)

Acpi table [SSDT] successfully installed and loaded

Loading Acpi table from file   DSDT.aml - Length 00052475 (00CCFB)

Acpi table [DSDT] successfully installed and loaded

Pass 1 parse of [DSDT]

Pass 2 parse of [DSDT]

Could not open input file: No such file or directory

 

 

Here is my procedure. I put my DDST.aml (the one you complied for me) and my SSDT.aml (the one I included in the post )into the same folder as iasl and ran the command line within the folder. Is it the correct procedure?



#6
RehabMan

RehabMan

    InsanelyMac Legend

  • Coders
  • 1,097 posts
  • Gender:Male
  • Location:Bellingham, WA
  • Interests:skiing, software, classic cars

Hello again, thanks for the info.  I tried the command line ./iasl -e [all ssdt except ssdtX.aml] DSDT.aml -d ssdtX.aml. But It gave the following error.
 
Loading Acpi table from file   ssdt.aml - Length 00013510 (0034C6)
Acpi table [SSDT] successfully installed and loaded
Loading Acpi table from file   DSDT.aml - Length 00052475 (00CCFB)
Acpi table [DSDT] successfully installed and loaded
Pass 1 parse of [DSDT]
Pass 2 parse of [DSDT]
Could not open input file: No such file or directory
 
 
Here is my procedure. I put my DDST.aml (the one you complied for me) and my SSDT.aml (the one I included in the post )into the same folder as iasl and ran the command line within the folder. Is it the correct procedure?


What was the command line you used?

#7
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

What was the command line you used?

 

The command line I used is the one you gave to me  "./iasl -e [all ssdt except ssdt.amlDSDT.aml -d ssdt.aml."



#8
RehabMan

RehabMan

    InsanelyMac Legend

  • Coders
  • 1,097 posts
  • Gender:Male
  • Location:Bellingham, WA
  • Interests:skiing, software, classic cars

The command line I used is the one you gave to me  "./iasl -e [all ssdt except ssdt.amlDSDT.aml -d ssdt.aml."


The "[all ssdt execept..]" part is a place holder. You must fill it in with the actual ssdt file name(s).

#9
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

The "[all ssdt execept..]" part is a place holder. You must fill it in with the actual ssdt file name(s).

 

excuse my noob move. :D I finished the compile, it was successful. I don't know what to say. Your solution works every time!

 

So I would like to know what is your suggestion to patch the SSDT. Do you think that I should patched the the brightness or start with patching the graphic card? And can I just copy and paste the coded content to the SSDT in the tutorial mentioned earlier (http://www.insanelym...brightnesskext/.)? 



#10
RehabMan

RehabMan

    InsanelyMac Legend

  • Coders
  • 1,097 posts
  • Gender:Male
  • Location:Bellingham, WA
  • Interests:skiing, software, classic cars

excuse my noob move. :D I finished the compile, it was successful. I don't know what to say. Your solution works every time!
 
So I would like to know what is your suggestion to patch the SSDT. Do you think that I should patched the the brightness or start with patching the graphic card? And can I just copy and paste the coded content to the SSDT in the tutorial mentioned earlier (http://www.insanelym...brightnesskext/.)? 


What is your graphics hardware?

#11
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

my graphic hardware is intel HD 4600


What is your graphics hardware?

 

My graphic hardware is Intel HD 4600



#12
RehabMan

RehabMan

    InsanelyMac Legend

  • Coders
  • 1,097 posts
  • Gender:Male
  • Location:Bellingham, WA
  • Interests:skiing, software, classic cars

my graphic hardware is intel HD 4600

 
My graphic hardware is Intel HD 4600


You should apply "Brightness Fix (Haswell)" from: https://github.com/R...ptop-DSDT-Patch
Then install: https://github.com/R...-ACPI-Backlight

Note: "Rename GFX0 to IGPU" is a prerequisite and must be applied to all DSDT/SSDT that you're loading.

#13
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

You should apply "Brightness Fix (Haswell)" from: https://github.com/R...ptop-DSDT-Patch
Then install: https://github.com/R...-ACPI-Backlight

Note: "Rename GFX0 to IGPU" is a prerequisite and must be applied to all DSDT/SSDT that you're loading.

 

 

So, I need to replace very "GFX0" word in DDST/SSDT with word "IGPU"?



#14
RehabMan

RehabMan

    InsanelyMac Legend

  • Coders
  • 1,097 posts
  • Gender:Male
  • Location:Bellingham, WA
  • Interests:skiing, software, classic cars

So, I need to replace very "GFX0" word in DDST/SSDT with word "IGPU"?


The repo has a patch for renaming... "Rename GFX0 to IGPU"

#15
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

The repo has a patch for renaming... "Rename GFX0 to IGPU"

 

Thank you! I will try that now and report back the result.



#16
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

The repo has a patch for renaming... "Rename GFX0 to IGPU"

 

There are something strange about ssdt.aml. After the compile and saving was successful, I opened the compiled ssdt.aml again, it restate the four error message I got earlier. So I decided to take the SSDT out of /Extra folder and try with only dsdt.aml. The renaming patch  works great, but after the Haswell brightness patch. I got 2 errors, which were

   

   Object does not exist (\_SB.PCI0.IGPU.BAR1)

   Object not found or not accessible from scope (^^PCI0.IGPU._DOS)

 

I attached the DSL file with the reply.

Attached Files

  • Attached File  DSDT.zip   38.07KB   0 downloads


#17
RehabMan

RehabMan

    InsanelyMac Legend

  • Coders
  • 1,097 posts
  • Gender:Male
  • Location:Bellingham, WA
  • Interests:skiing, software, classic cars

There are something strange about ssdt.aml. After the compile and saving was successful, I opened the compiled ssdt.aml again, it restate the four error message I got earlier. So I decided to take the SSDT out of /Extra folder and try with only dsdt.aml. The renaming patch  works great, but after the Haswell brightness patch. I got 2 errors, which were
   
   Object does not exist (\_SB.PCI0.IGPU.BAR1)
   Object not found or not accessible from scope (^^PCI0.IGPU._DOS)
 
I attached the DSL file with the reply.


"Brightness Fix (Hawell)" should be applied only to the SSDT containing the definition of your GFX0 device, not DSDT (unless DSDT contains your GFX0 device definition, of course).

Note: It is normal to have errors when you open the SSDT after patching, compiling, saving, etc. The errors are caused by an incorrect disassembly process (already discussed above). Disassemble it correctly, and there will be no errors.

#18
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

"Brightness Fix (Hawell)" should be applied only to the SSDT containing the definition of your GFX0 device, not DSDT (unless DSDT contains your GFX0 device definition, of course).

Note: It is normal to have errors when you open the SSDT after patching, compiling, saving, etc. The errors are caused by an incorrect disassembly process (already discussed above). Disassemble it correctly, and there will be no errors.

 

Hi, Unfortunately, it did not work. does it matter if DSDT is in capital or not? I put the dsdt and ssdt file all the /Extra folder. and none of them are in root.



#19
RehabMan

RehabMan

    InsanelyMac Legend

  • Coders
  • 1,097 posts
  • Gender:Male
  • Location:Bellingham, WA
  • Interests:skiing, software, classic cars

Hi, Unfortunately, it did not work. does it matter if DSDT is in capital or not? I put the dsdt and ssdt file all the /Extra folder. and none of them are in root.


Post ioreg using IORegistryExplorer v2.1.

#20
cjin5

cjin5

    InsanelyMac Protégé

  • Members
  • Pip
  • 40 posts

Post ioreg using IORegistryExplorer v2.1.

 

As requested, the ioreg file is attached.

Attached Files







0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users

© 2014 InsanelyMac  |   News  |   Forum  |   Downloads  |   OSx86 Wiki  |   Mac Netbook  |   PHP hosting by CatN  |   Designed by Ed Gain  |   Logo by irfan  |   Privacy Policy